BUG: Unignore .c files under _libs/src. (#42116) #42117
Conversation
| @@ -97,6 +97,8 @@ scikits | |||
| !np_datetime_strings.c | |||
| *.c | |||
| *.cpp | |||
| # Unignore source c files | |||
| !pandas/_libs/src/**/*.c | |||
There was a problem hiding this comment.
The np_datetime.c and np_datetime_strings.c above are in pandas/_libs/tslibs/src
maybe would could include .c files under any directory named src in the _libs tree
There was a problem hiding this comment.
I removed the np lines since they are caught by my new line. The line I added will ignore all c files under src/ so we're good there.
There was a problem hiding this comment.
I think it should be !pandas/_libs/**/src/**/*.c so that any .c files added to the pandas/_libs/tslibs/src are included in the future.
BUG: Remove unneeded gitignore lines. (pandas-dev#42116)
dalejung
force-pushed
the
fix_gitignore_for_src_c
branch
from
de44926 to
9be6afd
Compare
|
this is to not include the source in the distribution? where is this breaking? |
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
@dalejung can you address #42117 (comment) and merge upstream/master (should fix ci) |
|
Thanks for the PR, but it appears to have gone stale. Let us know if you're still interested in working on this and we can reopen. Closing. |
Not 100% what tests I could write for this. This works locally. git status shows no untracked files while
rg on_bad_linesnow shows results frompandas/_libs/src/parser/tokenizer.c